Regression Tests: Test helper events#1572
Closed
gitjain wants to merge 30 commits intomicrosoft:masterfrom
Closed
Conversation
joschect
approved these changes
Apr 24, 2017
| }); | ||
|
|
||
| function testRunner() { | ||
| componentIds.forEach(element => { |
Contributor
There was a problem hiding this comment.
I think you might be able to move test runner to your helper file.
Member
|
@joschect what's up with that big shrinkwrap file change? Is that appropriate? |
Contributor
|
If rush generate was run, then yes, but I don't think that would be needed. We should revert that. |
Member
|
One other request. @gitjain can we move the button tests into the individual folders? That button root level is really messy. |
micahgodbolt
requested changes
Apr 26, 2017
Member
micahgodbolt
left a comment
micahgodbolt
left a comment
There was a problem hiding this comment.
Clean up shrinkwrap and remove button tests from the root of the button folder.
Member
|
closing this as #1644 is doing the same |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Description of changes
(give an overview)
Focus areas to test
(optional)